Add support for T/t and P/p in fretboard fingerings (Fixes #23755)#31428
Add support for T/t and P/p in fretboard fingerings (Fixes #23755)#31428pyonpyoco wants to merge 5 commits intomusescore:masterfrom
Conversation
pyonpyoco
force-pushed
the
feature/fret-tp-fingering
branch
from
ba87f29 to
025ee51
Compare
|
@pyonpyoco Thanks for working on this. Would you mind rebasing so I can test this? As to mapping the letters to 6 and 7 in older versions, I think it would be better if we just wiped the field clear if they contained T/t/P/p. 6 and 7 don't map to any fingers after all, so it would be better to erase the marking entirely. |
pyonpyoco
force-pushed
the
feature/fret-tp-fingering
branch
from
025ee51 to
faa637d
Compare
|
@avvvvve Thanks, I’ve rebased onto the latest master so you can test it. I’ll take another look at the backward-compatibility behavior you suggested. Just to confirm: do you mean clearing only the unsupported T/t/P/p fingering entries for backward compatibility, while keeping valid numeric fingerings unchanged? |
|
@pyonpyoco Unfortunately there was a bug in the master branch yesterday that caused MSS to crash on startup. It's now been resolved, so could you please rebase this again? And yes, we'd only clear T/t/P/p entries, not valid numbers. |
2 participants
Resolves: #23755
Description:
This PR adds support for entering T/t (thumb) and P/p (pulgar) as fingering values for fretboard diagrams.
Changes:
Backward compatibility:
Opening scores using this feature in older versions (4.6.3) of MuseScore currently displays the digits 6 and 7.
Please advise if backward compatibility handling or a conversion layer is preferred.
UI example